Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the correct data types are sent in WebSocket messages from the client to the Worker #8083

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

jamesopstad
Copy link
Contributor

Fixes #000.

This fixes a bug where WebSocket messages from the client were always being received as ArrayBuffers in the Worker.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: only affects Vite plugin
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix

@jamesopstad jamesopstad requested review from a team as code owners February 10, 2025 19:05
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 5a37d3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamesopstad jamesopstad added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Feb 10, 2025
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-wrangler-8083

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8083/npm-package-wrangler-8083

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-wrangler-8083 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-workers-bindings-extension-8083 -O ./cloudflare-workers-bindings-extension.0.0.0-v3bc22b5a8.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3bc22b5a8.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-create-cloudflare-8083 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-kv-asset-handler-8083

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-miniflare-8083

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-pages-shared-8083

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-unenv-preset-8083

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-vite-plugin-8083

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-vitest-pool-workers-8083

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-workers-editor-shared-8083

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-workers-shared-8083

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13248468361/npm-package-cloudflare-workflows-shared-8083

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@threepointone
Copy link
Contributor

yessss. If this lands I can start using the beta builds asap

@petebacondarwin petebacondarwin merged commit 027698c into main Feb 10, 2025
23 of 24 checks passed
@petebacondarwin petebacondarwin deleted the james/fix-websocket-strings branch February 10, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vite-plugin Relating to the `@cloudflare/vite-plugin` package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants