Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide wrangler banner in secret list --format=json #8103

Merged
merged 8 commits into from
Feb 11, 2025
Merged

fix: hide wrangler banner in secret list --format=json #8103

merged 8 commits into from
Feb 11, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Feb 11, 2025 •
edited by penalosa
Loading

Fixes #8101

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: e2e should cover
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix

@emily-shen emily-shen requested a review from a team as a code owner February 11, 2025 20:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c15e52e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

penalosa
penalosa reviewed Feb 11, 2025
View reviewed changes
packages/wrangler/src/secret/index.ts Outdated
@@ -342,7 +343,13 @@ export const secretListCommand = createCommand({
hidden: true,
},
},
behaviour: {
printBanner: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

printBanner can be a function that decides whether to print based on the args— printBanner: (args) => args.format === "pretty",

@emily-shen @penalosa
Update .changeset/proud-days-study.md
8b725be 
Co-authored-by: Somhairle MacLeòid <[email protected]>
penalosa
penalosa reviewed Feb 11, 2025
View reviewed changes
packages/wrangler/src/secret/index.ts Outdated
@@ -19,6 +19,7 @@ import { requireAuth } from "../user";
import { getLegacyScriptName } from "../utils/getLegacyScriptName";
import { isLegacyEnv } from "../utils/isLegacyEnv";
import { readFromStdin, trimTrailingWhitespace } from "../utils/std";
import { printWranglerBanner } from "../wrangler-banner";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed

packages/wrangler/src/__tests__/secret.test.ts Outdated
Comment on lines 719 to 722
expect(std.out).toMatchInlineSnapshot(`
"Secret Name: the-secret-name
"
`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be showing the banner?

petebacondarwin
petebacondarwin approved these changes Feb 11, 2025
View reviewed changes
packages/wrangler/src/secret/index.ts
@@ -342,6 +342,9 @@ export const secretListCommand = createCommand({
hidden: true,
},
},
behaviour: {
printBanner: (args) => args.format === "pretty",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you didn't want to go with args.format !== "json"?

@github-actions GitHub Actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-wrangler-8103

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8103/npm-package-wrangler-8103

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-wrangler-8103 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workers-bindings-extension-8103 -O ./cloudflare-workers-bindings-extension.0.0.0-vb012923a4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb012923a4.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-create-cloudflare-8103 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-kv-asset-handler-8103

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-miniflare-8103

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-pages-shared-8103

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-unenv-preset-8103

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-vite-plugin-8103

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-vitest-pool-workers-8103

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workers-editor-shared-8103

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workers-shared-8103

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workflows-shared-8103

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa
Copy link
Contributor

For posterity—this does not affect C3, so merging without C3 tests fully finished

@penalosa penalosa merged commit a025ad2 into main Feb 11, 2025
27 of 29 checks passed
@penalosa penalosa deleted the emily/fix-secret-json branch February 11, 2025 22:13
@workers-devprod workers-devprod mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@penalosa penalosa penalosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: wrangler secret list --format json emits non-JSON characters
3 participants
@emily-shen @penalosa @petebacondarwin