Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Commit

Permalink
Remove "version: every" when "passed:" contraints are defined
Browse files Browse the repository at this point in the history
because that blocks automatic triggering of jobs

concourse/concourse#736

This combination of settting was introduced when we tried to force
Concourse to run later jobs on every version that passed the previous
one. E.g.
ver1 passed job 1, ver2 passed job 1
job2 should trigger both for ver1 and ver2 otherwise ver1 would never
be tested on job2. The new scheduling algorighm may have solved this:

https://concourse-ci.org/scheduler.html#scheduling-behavior

Given our pipeline needs us to manually trigger jobs all the time, this
worths a shot.
  • Loading branch information
Dimitris Karakasilis authored and Dimitris Karakasilis committed Aug 21, 2020
1 parent b20a0d9 commit d1c92cb
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions .concourse/pipeline.yaml.gomplate
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,6 @@ jobs:
- {{ . -}}{{ end }}
{{- end }}
trigger: true
version: "every"
passed:
- lint-{{ $branch }}
{{- if has $config.stable_jobs "build" }}
Expand Down Expand Up @@ -489,7 +488,6 @@ jobs:
- {{ . -}}{{ end }}
{{- end }}
trigger: true
version: "every"
passed:
- build-{{ $branch }}
- get: s3.kubecf-ci
Expand Down Expand Up @@ -722,7 +720,6 @@ jobs:
- {{ . -}}{{ end }}
{{- end }}
trigger: true
version: "every"
passed:
- deploy-{{ $cfScheduler }}-{{ $branch }}
- get: s3.kubecf-ci
Expand Down Expand Up @@ -901,7 +898,6 @@ jobs:
passed:
- {{ $previousTest | quote }}
trigger: true
version: "every"
- get: s3.kubecf-ci
{{- if $config.workertags }}
tags: {{ range $config.workertags }}
Expand Down Expand Up @@ -1068,7 +1064,6 @@ jobs:
passed:
- {{ $previousTest | quote }}
trigger: true
version: "every"
- get: s3.kubecf-ci
{{- if $config.workertags }}
tags: {{ range $config.workertags }}
Expand Down Expand Up @@ -1238,7 +1233,6 @@ jobs:
passed:
- {{ $previousTest | quote }}
trigger: true
version: "every"
- get: s3.kubecf-ci
{{- if $config.workertags }}
tags: {{ range $config.workertags }}
Expand Down Expand Up @@ -1406,7 +1400,6 @@ jobs:
passed:
- {{ $previousTest | quote }}
trigger: true
version: "every"
- get: s3.kubecf-ci
{{- if $config.workertags }}
tags: {{ range $config.workertags }}
Expand Down Expand Up @@ -1572,7 +1565,6 @@ jobs:
passed:
- {{ $previousTest | quote }}
trigger: true
version: "every"
- get: s3.kubecf-ci
{{- if $config.workertags }}
tags: {{ range $config.workertags }}
Expand Down Expand Up @@ -1736,7 +1728,6 @@ jobs:
# passed:
# - sync-integration-tests-{{ $cfScheduler }}
# trigger: true
# version: "every"
# - get: s3.kubecf-ci
# passed:
# - sync-integration-tests-{{ $cfScheduler }}
Expand Down Expand Up @@ -1803,7 +1794,6 @@ jobs:
passed:
- {{ $previousTest | quote }}
trigger: true
version: "every"
- get: semver.gke-cluster-{{ $config.resource_prefix | strings.Trunc 12 }}-{{ $branch | strings.Trunc 12 }}-{{ $cfScheduler }}
{{- if $config.workertags }}
tags: {{ range $config.workertags }}
Expand Down Expand Up @@ -1839,7 +1829,6 @@ jobs:
- {{ . -}}{{ end }}
{{- end }}
trigger: true
version: "every"
passed:
- build-{{ $branch }}
- get: s3.kubecf-ci
Expand Down

0 comments on commit d1c92cb

Please sign in to comment.