Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state to buildpacks output #2636

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add state to buildpacks output #2636

merged 1 commit into from
Dec 19, 2023

Conversation

philippthun
Copy link
Member

Fixes #2344. See #1952 (original issue) for more details.

Where this PR should be backported?

  • main - all changes should by default start here
  • v8
  • v7

@philippthun philippthun mentioned this pull request Oct 23, 2023
Closed
@philippthun philippthun force-pushed the add-state-to-buildpacks-output branch from 2c7c81d to 4357e1c Compare October 23, 2023 15:17
@moleske
Copy link
Member

moleske commented Oct 23, 2023

some integration tests are failing, posting an example failure so folks don't have to comb the integration tests in github themselves

 buildpacks command when the targeted API supports stack association [It] lists the buildpacks with the stack column 
/home/runner/work/cli/cli/integration/v7/isolated/buildpacks_command_test.go:51

  No future change is possible.  Bailing out early after 0.084s.
  Got stuck at:
      
      
      position   name                                                         stack        enabled   locked   state   filename
      1          staticfile_buildpack                                         cflinuxfs3   true      false    READY   staticfile_buildpack-cflinuxfs3-v1.6.2.zip
      2          staticfile_buildpack                                         cflinuxfs4   true      false    READY   staticfile_buildpack-cflinuxfs4-v1.6.2.zip
      3          java_buildpack                                               cflinuxfs3   true      false    READY   java-buildpack-cflinuxfs3-v4.58.zip
      4          java_buildpack                                               cflinuxfs4   true      false    READY   java-buildpack-cflinuxfs4-v4.58.zip
      5          ruby_buildpack                                               cflinuxfs3   true      false    READY   ruby_buildpack-cflinuxfs3-v1.10.1.zip
      6          ruby_buildpack                                               cflinuxfs4   true      false    READY   ruby_buildpack-cflinuxfs4-v1.10.1.zip
      7          dotnet_core_buildpack                                        cflinuxfs3   true      false    READY   dotnet-core_buildpack-cflinuxfs3-v2.4.10.zip
      8          dotnet_core_buildpack                                        cflinuxfs4   true      false    READY   dotnet-core_buildpack-cflinuxfs4-v2.4.10.zip
      9          nodejs_buildpack                                             cflinuxfs3   true      false    READY   nodejs_buildpack-cflinuxfs3-v1.8.9.zip
      10         nodejs_buildpack                                             cflinuxfs4   true      false    READY   nodejs_buildpack-cflinuxfs4-v1.8.9.zip
      11         go_buildpack                                                 cflinuxfs3   true      false    READY   go_buildpack-cflinuxfs3-v1.10.8.zip
      12         go_buildpack                                                 cflinuxfs4   true      false    READY   go_buildpack-cflinuxfs4-v1.10.8.zip
      13         python_buildpack                                             cflinuxfs3   true      false    READY   python_buildpack-cflinuxfs3-v1.8.9.zip
      14         python_buildpack                                             cflinuxfs4   true      false    READY   python_buildpack-cflinuxfs4-v1.8.9.zip
      15         php_buildpack                                                cflinuxfs3   true      false    READY   php_buildpack-cflinuxfs3-v4.6.4.zip
      16         php_buildpack                                                cflinuxfs4   true      false    READY   php_buildpack-cflinuxfs4-v4.6.4.zip
      17         nginx_buildpack                                              cflinuxfs3   true      false    READY   nginx_buildpack-cflinuxfs3-v1.2.2.zip
      18         nginx_buildpack                                              cflinuxfs4   true      false    READY   nginx_buildpack-cflinuxfs4-v1.2.2.zip
      19         r_buildpack                                                  cflinuxfs3   true      false    READY   r_buildpack-cflinuxfs3-v1.2.1.zip
      20         r_buildpack                                                  cflinuxfs4   true      false    READY   r_buildpack-cflinuxfs4-v1.2.1.zip
      21         binary_buildpack                                             cflinuxfs3   true      false    READY   binary_buildpack-cflinuxfs3-v1.1.4.zip
      22         binary_buildpack                                             cflinuxfs4   true      false    READY   binary_buildpack-cflinuxfs4-v1.1.4.zip
      23         INTEGRATION-BUILDPACK-19139db0-0d5f-4ca5-6f86-6e70a1e8fc02   cflinuxfs3   true      false    READY   buildpack-archive-file-705305173.zip
      24         INTEGRATION-BUILDPACK-5e25088b-2c8d-4c46-46c8-56e5259bfb19   cflinuxfs3   true      false    READY   buildpack-archive-file-1650460258.zip
      
  Waiting for:
      position\s+name\s+stack\s+enabled\s+locked\s+filename

  /home/runner/work/cli/cli/integration/v7/isolated/buildpacks_command_test.go:56

Basically in https://github.com/cloudfoundry/cli/blob/main/integration/v7/isolated/buildpacks_command_test.go#L56 (and maybe others?) the integration tests are looking for a specific list of column names and the new state column is not accounted for

@philippthun philippthun force-pushed the add-state-to-buildpacks-output branch from 4357e1c to 1a5adac Compare October 26, 2023 11:27
@philippthun philippthun force-pushed the add-state-to-buildpacks-output branch from 1a5adac to a566144 Compare October 26, 2023 14:09
@beyhan beyhan mentioned this pull request Nov 17, 2023
Merged
@ccjaimes
Copy link
Contributor

Hey @philippthun, we are looking to merge this PR. Could you kindly create an additional PR with these changes pointing to v8 branch please?

@philippthun
Copy link
Member Author

Hey @philippthun, we are looking to merge this PR. Could you kindly create an additional PR with these changes pointing to v8 branch please?

Here is the corresponding PR against the v8 branch: #2699

ccjaimes
ccjaimes approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ccjaimes ccjaimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution

@ccjaimes ccjaimes merged commit e2020e2 into cloudfoundry:main Dec 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccjaimes ccjaimes ccjaimes approved these changes

@a-b a-b a-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-open #1952
5 participants
@philippthun @moleske @ccjaimes @a-b @cf-gitbot