Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chocolatey packaging for Windows #2767

Closed
wants to merge 1 commit into from

Conversation

sneal
Copy link
Contributor

@sneal sneal commented Feb 1, 2024

This migrates and modernizes the existing CF CLI Chocolatey packaging scripts that currently execute separately in AppVeyor. This enables the CF CLI to have a single point of release and management for all OSes.

Prereqs

  • The workflow requires a CHOCO_API_KEY secret so new packages can be submitted for moderation. Eventually we should ask for Chocolatey moderation to be removed since this is an official release channel.
  • Windows2019 workers with .NET Framework 4.8 already installed. This workflow should work on Windows 2022, but I primarily tested this using 2019.
  • The workflow installed Chocolatey as a first step. This could be baked into the base worker image.

Fixed Chocolatey moderation issues

  • Added checksums to 32bit and 64bit packages
  • Removed ProjectSourceUrl that was the same as ProjectUrl causing a choco submission warning

Copy link

CLA Not Signed

Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b
Copy link
Member

a-b commented Feb 2, 2024

Closing in favor of #2770 and #2769

@a-b a-b closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants