Add CurrentDropletGUID attribute to application resource [main] #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
joaopapereira
requested changes
Jan 21, 2025
| @@ -42,10 +44,18 @@ func (a Application) MarshalJSON() ([]byte, error) { | |||
| Metadata: a.Metadata, | |||
| } | |||
|
|
|||
| relationShips := Relationships{} | |||
There was a problem hiding this comment.
Suggested change
| relationShips := Relationships{} | |
| relationships := Relationships{} |
| ccApp.Relationships = Relationships{ | ||
| constant.RelationshipTypeSpace: Relationship{GUID: a.SpaceGUID}, | ||
| } | ||
| relationShips[constant.RelationshipTypeSpace] = Relationship{GUID: a.SpaceGUID} |
There was a problem hiding this comment.
Suggested change
| relationShips[constant.RelationshipTypeSpace] = Relationship{GUID: a.SpaceGUID} | |
| relationships[constant.RelationshipTypeSpace] = Relationship{GUID: a.SpaceGUID} |
| } | ||
|
|
||
| if a.CurrentDropletGUID != "" { | ||
| relationShips[constant.RelationshipTypeCurrentDroplet] = Relationship{GUID: a.CurrentDropletGUID} |
There was a problem hiding this comment.
Suggested change
| relationShips[constant.RelationshipTypeCurrentDroplet] = Relationship{GUID: a.CurrentDropletGUID} | |
| relationships[constant.RelationshipTypeCurrentDroplet] = Relationship{GUID: a.CurrentDropletGUID} |
| relationShips[constant.RelationshipTypeCurrentDroplet] = Relationship{GUID: a.CurrentDropletGUID} | ||
| } | ||
|
|
||
| if len(relationShips) > 0 { |
There was a problem hiding this comment.
Do we really need this if statement here? if we could I would prefer to have it removed and always set relationships in the struct
| } | ||
|
|
||
| if len(relationShips) > 0 { | ||
| ccApp.Relationships = relationShips |
There was a problem hiding this comment.
Suggested change
| ccApp.Relationships = relationShips | |
| ccApp.Relationships = relationships |
|
I updated the current PR with the latest changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where this PR should be backported?
Description of the Change
The V3 API now allows you to access to the relationships existing beween an app and its current droplet.
This PR make this relationship visible trough a new
CurrentDropletGUIDattribute in the resourceapplication.The community
cf_exportercurrently use the/v2/spaces/:guid/summaryendpoint to gain access to buildpack associated to an application. Have this relationship visible would help get rid of calls on this endpoint and retrieve informations from bbs about DesiredLRPs and RunningLRPS.This feature will not cause breaking change.