Log when DB queries return large numbers of rows #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andy-paine thanks for the PR. Is there an associated capi-release PR to allow configuration of the |
Co-authored-by: andy-paine <[email protected]>
Threshold acts as both a way to avoid polluting logs with queries that only produce a few rows as well as a way to toggle this behaviour off so it only affects users who opt-in
andy-paine
force-pushed
the
log-db-row-counts
branch
from
58ad219 to
7c063f7
Compare
andy-paine
added a commit
to sap-contributions/capi-release
that referenced
this pull request
Jul 28, 2021
Allow configuring of the threshold above which large queries should be logged See cloudfoundry/cloud_controller_ng#2338
3 tasks
|
Rebased this branch and added a CAPI PR cloudfoundry/capi-release#200 now 🙂 |
Ensure that extra logs will only be emitted when user opts in by providing threshold
The format of these logs is slightly different between mysql and postgres but they seem functionally the same so we can just test for either type of quoting
andy-paine
force-pushed
the
log-db-row-counts
branch
from
7c063f7 to
e1ff12c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change
Add some extra logging for when DB queries return a large number of rows including a configuration flag which can both toggle the feature off as well as set a threshold for when to log.
An explanation of the use cases your change solves
We've seen some DB queries return large numbers of rows which CC then has to parse/marshal which can be particularly slow. By adding some additional logging when queries return lots of data we can hopefully identify specific requests that cause large numbers or rows to be handled.
We've also looked at using pg_stat_statments but by using the existing Steno logger in CC we can identify a specific request as our users submit error reports about slow endpoints including the VCAP request ID.
Links to any other associated PRs
Slow service plan visibilities caused by large numbers of returned rows - #2215
Checks
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests