Fix add missing typescript definitions #201
Conversation
| * @param {string} [publicId] | ||
| * @param {Object} [options] |
There was a problem hiding this comment.
Used the same format as the ImageTag class (copy-paste), do you want me to add a more descriptive line like lines 724-725?
| export class SourceTag extends HtmlTag { | ||
| static "new"(publicId: string, options?: Transformation.Options): SourceTag; | ||
| static "new"(name: string, publicId: string, options?: Transformation.Options): SourceTag; | ||
| } |
There was a problem hiding this comment.
@eyalktCloudinary , how do I use this sourceTag? in pictureTag? in videoTag?
There was a problem hiding this comment.
A SourceTag instance is returned by sourceTag() (cloudinary.js), though I couldn't find any invocations of this function. The client that has raised this issue has found the function in our code and tries to use it, but couldn't - #189
There was a problem hiding this comment.
I'm guessing we're supposed to use it in pictureTag to create
<picture><source></source></picture>
but it seems that we're not
There was a problem hiding this comment.
@eyalktCloudinary , let's check how this is used before we merge the PR
There was a problem hiding this comment.
I think this is an internal class was exposed(alone and as a builder), but was never documented.
We use new SourceTag() in pictureTag, but I don't think we ever meant for the sourceTag itself to work in isolation, and for it to be public.
|
Closing as this will need to be redone anyway after picture-tag is updated |
ghost
closed this
ghost
deleted the
No description provided.