Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/types docs #233

Merged
2 commits merged into from
Jun 18, 2020
Merged

Fix/types docs #233

2 commits merged into from
Jun 18, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 18, 2020 •
edited by ghost
Loading

This pr updates type definitions:

  1. I noticed that font antialiasing was misspelled, so fixed it.
  2. Users have typescript warnings when following the example for using the Cloudinary class, see: Property 'new' is a static member of type 'Cloudinary' #192
    So updated the example.

@ghost ghost requested review from jackieros, strausr, asisayag2 and patrick-tolosa June 18, 2020 05:00
@ghost ghost removed the request for review from jackieros June 18, 2020 10:54
@ghost ghost merged commit 91c6d1c into master Jun 18, 2020
@ghost ghost deleted the fix/types-docs branch July 1, 2020 09:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strausr @asisayag2 @patrick-tolosa @nirmaoz