Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent video on safari 14.1 by using fetch instead of XHR #282

Merged
3 commits merged into from
Jan 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2022

Brief Summary of Changes

This pr fixes a bug where transparent video did not work in safari 14.1.
The pr changes the getBlobFromURL() to prefer usage of the fetch function over XHR, which works on safari 14.1.

@ghost ghost requested a review from patrick-tolosa January 5, 2022 16:22
@ghost ghost requested review from patrick-tolosa and strausr January 6, 2022 05:50
@ghost ghost merged commit 7654e56 into master Jan 6, 2022
@ghost ghost deleted the fix/transparent-video-safari-14.1 branch January 6, 2022 07:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants