Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Fix the TF State Resource Name #21

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Fix the TF State Resource Name #21

merged 3 commits into from
Jun 6, 2023

Conversation

milldr
Copy link
Contributor

@milldr milldr commented Jun 6, 2023

what

  • Adding root to the resource name

why

  • Correct backend to properly reference state

references

@milldr milldr requested review from a team as code owners June 6, 2023 16:06
@milldr milldr requested review from jamengual and woz5999 June 6, 2023 16:06
aknysh
aknysh reviewed Jun 6, 2023
View reviewed changes
Copy link

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@milldr milldr merged commit 574fc00 into main Jun 6, 2023
@milldr milldr deleted the debug-060623 branch June 6, 2023 16:51
Mr0grog added a commit to usdigitalresponse/univaf that referenced this pull request Jun 14, 2023
@Mr0grog
Add note about AWS Terraform provider version
a79b44a 
We use a Terraform module that isn't yet compatible with v5 of the AWS provider, and this adds a note about the situation, since it might not be clear to someone coming in fresh to the codebase. Hopefully Cloudposse will update the module we use, but it doesn't look like that's coming soon, given that they recently updated their tutorials to specify AWS < 5. (See cloudposse-archives/tutorials#21 (comment))
Mr0grog added a commit to usdigitalresponse/univaf that referenced this pull request Jun 14, 2023
@Mr0grog
Add note about AWS Terraform provider version
a74dc09 
We use a Terraform module that isn't yet compatible with v5 of the AWS provider, and this adds a note about the situation, since it might not be clear to someone coming in fresh to the codebase. Hopefully Cloudposse will update the module we use, but it doesn't look like that's coming soon, given that they recently updated their tutorials to specify AWS < 5. (See cloudposse-archives/tutorials#21 (comment))
@Mr0grog Mr0grog mentioned this pull request Jun 14, 2023
Merged
Mr0grog added a commit to usdigitalresponse/univaf that referenced this pull request Jun 14, 2023
@Mr0grog
Add note about AWS Terraform provider version (#1568)
c2296ba 
We use a Terraform module that isn't yet compatible with v5 of the AWS provider, and this adds a note about the situation, since it might not be clear to someone coming in fresh to the codebase. Hopefully Cloudposse will update the module we use, but it doesn't look like that's coming soon, given that they recently updated their tutorials to specify AWS < 5. (See cloudposse-archives/tutorials#21 (comment))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osterman osterman osterman left review comments

@aknysh aknysh aknysh approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milldr @osterman @aknysh