Always run fixtures

[goruha]

what

• Always run fixtures for terratest workflow

Summary by CodeRabbit

• New Features

  • Streamlined workflow for GitHub Actions, enhancing job execution consistency.

• Bug Fixes

  • Removed unnecessary conditional logic, ensuring all jobs run as expected.

[coderabbitai]

Walkthrough

The pull request modifies the GitHub Actions workflow in .github/workflows/shared-terraform-chatops.yml. The changes simplify the workflow's structure by removing the fixture_id job and streamlining job conditions and artifact handling. The workflow now has a more direct approach to managing test fixtures, artifact downloads, and job dependencies, reducing the complexity of conditional logic across different jobs.

Changes

File	Change Summary
.github/workflows/shared-terraform-chatops.yml	- Removed fixture_id job - Simplified cleanup job condition to always run - Updated terratest job to remove fixture-related conditionals - Modified artifact download to always use state artifact

Poem

🐰 Workflow dance, simplified and bright,
Conditions trimmed with rabbit's might!
No more complex fixture play,
Actions flow in a clearer way
GitHub's magic, lean and light! 🚀

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mergify]

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

[coderabbitai]

Actionable comments posted: 0

🔭 Outside diff range comments (2)

.github/workflows/shared-terraform-chatops.yml (2)

Line range hint 587-591: Fix cleanup job configuration

Multiple issues in the cleanup job configuration:

1. Job depends on removed fixture_id job
2. References non-existent test_fixture_id output

Apply these fixes:

- needs: [context, terratest, fixture_id]
+ needs: [context, terratest, fixtures]
  env:
    MAKE_INCLUDES: Makefile
    AWS_REGION: us-east-2
    AWS_ROLE_TO_ASSUME: ${{ needs.context.outputs.test_aws_role }}
-   TEST_FIXTURE_ID: ${{ needs.context.outputs.test_fixture_id }}

🧰 Tools

🪛 actionlint (1.7.4)

586-586: job "cleanup" needs job "fixture_id" which does not exist in this workflow

(job-needs)

---

Line range hint 651-655: Fix artifact download configuration

The artifact download step is using a removed output variable for the artifact name.

Apply this fix:

  uses: actions/download-artifact@v4
  with:
-   name: ${{ needs.context.outputs.test_fixture_id }}
+   name: state
    path: ${{ needs.context.outputs.terraform_state_path }}

🧹 Nitpick comments (1)

.github/workflows/shared-terraform-chatops.yml (1)

Line range hint 1-1: Workflow simplification is a good improvement

The changes to always run fixtures and simplify the workflow structure are good improvements that will make the workflow more reliable and easier to maintain. The removal of conditional logic and consistent artifact handling will reduce potential points of failure.

Consider adding timeouts to the long-running jobs (fixtures, terratest, cleanup) to prevent them from running indefinitely in case of issues.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7146187 and e31c32a.

📒 Files selected for processing (1)

• .github/workflows/shared-terraform-chatops.yml (2 hunks)

🔇 Additional comments (1)

.github/workflows/shared-terraform-chatops.yml (1)

530-533: ⚠️ Potential issue

Fix job dependency on removed fixture_id job

The terratest job still lists fixture_id in its needs array, but this job has been removed. This will cause the workflow to fail.

Apply this fix:

  needs: [context, pending, fixture_id]

to

  needs: [context, pending, fixtures]

Likely invalid or redundant comment.