Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always create new comments for release #111

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Always create new comments for release #111

merged 2 commits into from
Jun 27, 2024

Conversation

goruha
Copy link
Member

@goruha goruha commented Jun 27, 2024

what

  • Always create new comments for release

why

  • We do not need to update comments as release usually triggered only once

references

  • DEV-2360 GHA Bot to comment instead of edit an existing comment

@goruha goruha requested review from a team as code owners June 27, 2024 16:45
@goruha goruha requested review from johncblandii and gberenice June 27, 2024 16:45
@mergify mergify bot added triage Needs triage needs-cloudposse Needs Cloud Posse assistance labels Jun 27, 2024
@mergify Mergify
Copy link

mergify bot commented Jun 27, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

Benbentwo
Benbentwo previously approved these changes Jun 27, 2024
View reviewed changes
@mergify mergify bot removed the triage Needs triage label Jun 27, 2024
@goruha goruha requested review from osterman and Benbentwo June 27, 2024 18:32
@goruha goruha merged commit d0c22e7 into main Jun 27, 2024
5 checks passed
@goruha goruha deleted the always-create-comment-on-release branch June 27, 2024 21:09
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

@osterman osterman Awaiting requested review from osterman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goruha @osterman @Benbentwo