Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict role that can run terratest #122

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Restrict role that can run terratest #122

merged 5 commits into from
Sep 6, 2024

Conversation

goruha
Copy link
Member

@goruha goruha commented Sep 6, 2024 •
edited
Loading

what

  • Restrict terratest run only to OWNER, MEMBER, COLLOBORATOR
  • Allow terratest run only for open PR

why

  • Avoid random users to run terratest (because of cost and security reason)
  • Do not run tests for closed PRs

references

@goruha goruha requested review from a team as code owners September 6, 2024 20:01
@goruha goruha requested review from kevcube and gberenice September 6, 2024 20:01
@mergify mergify bot added the triage Needs triage label Sep 6, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 6, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Sep 6, 2024
@mergify mergify bot removed the triage Needs triage label Sep 6, 2024
@goruha goruha merged commit 9549f8d into main Sep 6, 2024
5 checks passed
@goruha goruha deleted the fix-security-permissions branch September 6, 2024 20:15
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goruha @Nuru