Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more conditions for mergify config #49

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Add more conditions for mergify config #49

merged 8 commits into from
Mar 14, 2024

Conversation

osterman
Copy link
Member

@osterman osterman commented Mar 10, 2024

what

  • Check that PR is not a WIP when commenting
  • Use explict and everywhere needed in anchors
  • Delay 5 minutes since last update before welcoming
  • Label stale pull requests
  • Close stale pull requests 3 days after last update
  • Use active voice
  • Rename anchors to be more clear
  • Use more anchors to make it easier to understand what everything means

why

  • Some edge cases we encountered
  • Make mergify less error prone

@osterman osterman requested a review from a team as a code owner March 10, 2024 03:41
@mergify mergify bot added the triage Needs triage label Mar 10, 2024
Copy link

mergify bot commented Mar 10, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Mar 10, 2024
@osterman osterman requested a review from a team as a code owner March 10, 2024 16:40
@joe-niland joe-niland self-requested a review March 11, 2024 09:33
Copy link
Contributor

@hans-d hans-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, not blocking for merge

.github/mergify.yml Outdated Show resolved Hide resolved
.github/mergify.yml Outdated Show resolved Hide resolved
.github/mergify.yml Show resolved Hide resolved
.github/mergify.yml Outdated Show resolved Hide resolved
.github/mergify.yml Show resolved Hide resolved
@osterman osterman merged commit 40489ed into main Mar 14, 2024
5 of 6 checks passed
@osterman osterman deleted the fix-mergify branch March 14, 2024 04:01
@mergify mergify bot removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants