Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shared github action workflow] Get rid of ref input #94

Merged
merged 1 commit into from
May 17, 2024
Merged

[shared github action workflow] Get rid of ref input #94

merged 1 commit into from
May 17, 2024

Conversation

goruha
Copy link
Member

@goruha goruha commented May 17, 2024

what

  • Replace ref input with expression

why

  • Use github.ref for push events and github.pull_request.head.ref

@goruha goruha requested review from a team as code owners May 17, 2024 20:55
@goruha goruha requested review from kevcube and RoseSecurity May 17, 2024 20:55
@mergify mergify bot added triage Needs triage needs-cloudposse Needs Cloud Posse assistance labels May 17, 2024
@mergify Mergify
Copy link

mergify bot commented May 17, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@goruha goruha merged commit 3dae3ef into main May 17, 2024
5 checks passed
@goruha goruha deleted the shared-github-action-workflow-remove-ref branch May 17, 2024 20:57
@mergify mergify bot removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@goruha