Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README template to use canonical URLs #95

Merged
merged 3 commits into from
May 17, 2024
Merged

Update README template to use canonical URLs #95

merged 3 commits into from
May 17, 2024

Conversation

osterman
Copy link
Member

what

  • Serve banner from canonical URL

why

  • Terraform registry doesn't support relative URLs 💩

@osterman osterman requested review from a team as code owners May 17, 2024 22:09
@osterman osterman requested review from hans-d and joe-niland May 17, 2024 22:09
@mergify mergify bot added the triage Needs triage label May 17, 2024
@mergify mergify bot removed the triage Needs triage label May 17, 2024
@osterman osterman merged commit 4831149 into main May 17, 2024
5 checks passed
@osterman osterman deleted the update-readme branch May 17, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @milldr