Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github/download-private-release when GITHUB_TOKEN exists #52

Open
goruha opened this issue Apr 2, 2018 · 1 comment
Open

Use github/download-private-release when GITHUB_TOKEN exists #52

goruha opened this issue Apr 2, 2018 · 1 comment
Labels
feature request

Comments

@goruha
Copy link
Member

goruha commented Apr 2, 2018 •
edited by osterman
Loading

What

  • Refactor github/download-public-release to use github/download-private-release
    if GITHUB_TOKEN exists.

Why

  • If GITHUB_TOKEN exists we use an authenticated call that has limits 5000 per day per IP
    else we call anonymous call that has limits to 60 per day per IP.

Workaround

  • Make exits non-zero error if anonymous request limit hit.
@osterman
Copy link
Member

I think we should move to using fetch: https://github.com/gruntwork-io/fetch

charlieparkes added a commit to charlieparkes/build-harness that referenced this issue Jul 1, 2020
@charlieparkes
Add Makefile.security inside modules/python with python/bandit target (…
428a9a7 
…cloudposse#52)

* Add Makefile.security inside modules/python with python/bandit target

* Use generic PYTHON_LINT_TARGETS since static analysis like bandit is indeed linting. Add newline to requirements.template

* Combine common Lint and Security targets. Use lint Makefile style for securit Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@osterman @goruha