Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to auto-release.yml files to include PR body + use minor > patch as default #242

Closed
wants to merge 2 commits into from
Closed

Updates to auto-release.yml files to include PR body + use minor > patch as default #242

wants to merge 2 commits into from

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Aug 15, 2020

what

  • Updates change-template to include the PR body
  • Updates to bump the minor as the default instead of bumping patch

why

  • Our PR bodies typically have good information in them due to our PR body template being simple and straightforward. It's good to include that in our release notes as most folks likely won't check the PR itself.
  • We do minor releases much more frequently than patch so using minor as our default makes sense to save us time in regards to merging without a label.

@Gowiem Gowiem requested a review from osterman August 15, 2020 00:15
@Gowiem Gowiem requested review from a team as code owners August 15, 2020 00:15
@Gowiem Gowiem self-assigned this Aug 15, 2020
@Gowiem Gowiem requested a review from nitrocode August 15, 2020 00:15
@github-actions github-actions bot requested review from aknysh and goruha August 15, 2020 00:16
osterman
osterman reviewed Aug 15, 2020
View reviewed changes
.github/auto-release.yml
@@ -29,7 +29,10 @@ categories:
- 'bug'
- 'hotfix'

change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
change-template: |
## $TITLE @$AUTHOR (#$NUMBER)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I considered doing this, but our descriptions have ## in them usually.

image

See #241

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cloudposse/build-harness/releases/tag/0.40.0

@osterman osterman mentioned this pull request Aug 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman left review comments

@nitrocode nitrocode Awaiting requested review from nitrocode

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@Gowiem Gowiem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gowiem @osterman