Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize GitHub Issue Templates #325

Merged
merged 10 commits into from
Feb 16, 2023
Merged

Modernize GitHub Issue Templates #325

merged 10 commits into from
Feb 16, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jul 15, 2022 •
edited by osterman
Loading

what

  • Convert bug report type to yaml
  • Convert feature request type to yaml
  • Use comments and dashes in PR template
  • Get reviews from multiple team members

why

  • Modernize our templates
  • Use YAML so the prompts are more structured
  • Comment out PR template placeholder text so the user can add uncommented text without having to delete the placeholder text
  • Dashes in PR template instead of asterisks as this is recommended by prettier and it saves some typing. The dash is a single key whereas the asterisk is a SHIFT + 8.
    • @korenyoni originally recommended this and we've been doing this in clients.

references

image

image

@nitrocode nitrocode requested review from a team as code owners July 15, 2022 21:40
@github-actions github-actions bot requested review from aknysh, goruha and osterman July 15, 2022 21:40
@nitrocode nitrocode requested review from Gowiem and Nuru and removed request for goruha July 15, 2022 21:40
@nitrocode nitrocode requested a review from korenyoni July 17, 2022 15:59
@osterman osterman merged commit 84037a9 into master Feb 16, 2023
@osterman osterman deleted the update-templates branch February 16, 2023 15:17
@osterman osterman changed the title Modernize templates Modernize GitHub Issue Templates Feb 16, 2023
@nitrocode nitrocode mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@osterman osterman osterman approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 is a code owner automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew is a code owner automatically assigned from cloudposse/contributors

@Gowiem Gowiem Awaiting requested review from Gowiem

@Nuru Nuru Awaiting requested review from Nuru

@korenyoni korenyoni Awaiting requested review from korenyoni

Assignees

@nitrocode nitrocode

Labels
modules/github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitrocode @osterman @aknysh @Nuru