Use Organization's .github README.md.gotmpl
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
changed the title
README.md.gotmpl
goruha
previously approved these changes
Jan 25, 2024
osterman
commented
Jan 26, 2024
Nuru
previously approved these changes
Jan 26, 2024
Nuru
approved these changes
Jan 26, 2024
osterman
commented
Jan 30, 2024
.dockerignore
Outdated
| @@ -1 +1,2 @@ | |||
| .git/* | |||
There was a problem hiding this comment.
@Nuru these commands rely on
git remote get-url which doesn't work with out .git, which means it won't work in geodesic
osterman
commented
Jan 30, 2024
| export README_TEMPLATE_FILE ?= $(BUILD_HARNESS_PATH)/templates/README.md.gotmpl | ||
| export README_TEMPLATE_YAML := $(if $(findstring http,$(README_YAML)),$(README_YAML),$(BUILD_HARNESS_PATH)/templates/$(README_YAML)) | ||
| export README_INCLUDES ?= $(file://$(shell pwd)/?type=text/plain) |
There was a problem hiding this comment.
@Nuru this is needed by the README.md.gotmpl which uses it as the base for including other files (e.g. from docs/)
There was a problem hiding this comment.
With this syntax, README_INCLUDES is always empty. Probably meant for it to be automatically including $PWD but since it never worked, I would rather just remove it from the template.
- added in Dynamic datasources support #100
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
readme/buildto depend on templatewhy