Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate packages install path from other uses of INSTALL_PATH #377

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Disambiguate packages install path from other uses of INSTALL_PATH #377

merged 1 commit into from
Feb 3, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 3, 2024

what

  • Use PACKAGES_INSTALL_PATH instead of INSTALL_PATH to determine where build-harness installs its tools

why

  • Other Makefiles use INSTALL_PATH to determine where to install their build artifacts (typically /usr/local/bin) but that does not mean build-harness should be installing its tools there

@Nuru Nuru requested review from osterman and joe-niland February 3, 2024 07:58
@Nuru Nuru requested review from a team as code owners February 3, 2024 07:58
@Nuru Nuru requested a review from dotCipher February 3, 2024 07:58
@github-actions github-actions bot requested review from aknysh and goruha February 3, 2024 07:59
@Nuru Nuru added the bugfix Change that restores intended behavior label Feb 3, 2024
@Nuru Nuru merged commit 420c75b into master Feb 3, 2024
14 checks passed
@Nuru Nuru deleted the install-path branch February 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@Nuru Nuru

Labels
bugfix Change that restores intended behavior modules/packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @osterman