Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable strict mode for helm lint #53

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Conversation

goruha
Copy link
Member

@goruha goruha commented Apr 4, 2018

What

  • Disable strict mode for helm lint

Why

  • It pay attention to non existed values in values.yaml like fullnameOverride
    But fullnameOverride is a pattern for chart naming and should not be defined in values.yaml
    The same case with global values
✅   (assume-role staging:39m) portal ➤  helm lint --strict
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/: render error in "portal/templates/proxy.service.yaml": template: portal/templates/proxy.service.yaml:5:11: executing "portal/templates/proxy.service.yaml" at <include "portal.prox...>: error calling include: template: portal/charts/common/templates/_fullname.tpl:21:39: executing "common.fullname" at <.Values.global>: map has no entry for key "global"

@goruha goruha requested a review from osterman April 4, 2018 20:51
@goruha goruha requested a review from aknysh April 4, 2018 20:56
@goruha goruha merged commit dbae215 into master Apr 4, 2018
@goruha goruha deleted the fix-disable-strict-helm-linting branch April 4, 2018 21:09
charlieparkes added a commit to charlieparkes/build-harness that referenced this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants