Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path #55

Merged
merged 2 commits into from
May 2, 2018
Merged

Fix path #55

merged 2 commits into from
May 2, 2018

Conversation

osterman
Copy link
Member

@osterman osterman commented May 2, 2018 •
edited
Loading

what

  • Do not use which, especially with :=
  • Set search path to include vendor directory

why

  • If binary is not already installed, which will fail
  • Search path did not look for vendor directory
  • Using := prevents reassignment

@osterman osterman requested a review from goruha May 2, 2018 05:41
@osterman
Copy link
Member Author

osterman commented May 2, 2018

Related: https://travis-ci.org/cloudposse/charts/builds/373774418

@osterman osterman merged commit 98b8dc8 into master May 2, 2018
@goruha goruha deleted the fix-path branch May 2, 2018 05:46
charlieparkes added a commit to charlieparkes/build-harness that referenced this pull request Jul 17, 2020
@charlieparkes
Make bh/venv's ability to skip existing packages configurable, and tu…
737fc85 
…rn it off by default (cloudposse#55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goruha goruha goruha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @goruha