Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm status infinite loop #58

Merged
merged 3 commits into from
May 4, 2018
Merged

Fix helm status infinite loop #58

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d9c9af
delete \n instead of replacing with a ,
sarkis May 3, 2018
d976035
cleaner info output with echo
sarkis May 3, 2018
642bea2
fix indent
sarkis May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/helm_toolbox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function check() {
wait_for_helm() {
info "Waiting for helm tiller..."
while true; do
status=$(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system | tr '\n' ',')
status=$(echo $(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system))
info "Helm status: $status"
if [ "$status" = "Running" ]; then
break;
Expand Down