Skip to content

0.2.1
Compare
Choose a tag to compare
@aknysh aknysh released this 21 Feb 20:11
· 229 commits to master since this release
0.2.1
fb4f77f
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

what

  • Check Docker credentials in docker:login
  • Don't login to Docker if credentials are missing

why

  • For external PRs (not originating from the original repo), for security reasons CI environments like Travis don't provide the ENV vars specified in repo Settings, and Docker login fails
$ make docker:login
DOCKER_HUB_USERNAME not defined in docker:login
make: *** [docker:login] Error 1
The command "make docker:login" failed and exited with 2 during .
Assets 2
Loading