[monochart] Update envFrom (#253)

cloudposse · Jul 16, 2020 · f52c7f9 · f52c7f9
1 parent 527aca3
commit f52c7f9
Showing 1 changed file with 13 additions and 14 deletions.
diff --git a/incubator/monochart/templates/_helpers.tpl b/incubator/monochart/templates/_helpers.tpl
@@ -23,7 +23,7 @@ Environment template block for deployable resources
 */}}
 {{- define "monochart.env" -}}
 {{- $root := . -}}
-{{- if or $root.Values.configMaps $root.Values.secrets }}
+{{- if $root.Values.configMaps | or $root.Values.secrets | or $root.Values.envFrom }}
 envFrom:
 {{- range $name, $config := $root.Values.configMaps -}}
 {{- if $config.enabled }}
@@ -41,27 +41,26 @@ envFrom:
 {{- end }}
 {{- end }}
 {{- end }}
-{{- end }}
-{{- with $root.Values.env }}
-env:
-{{- range $name, $value := . }}
-  - name: {{ $name }}
-    value: {{ default "" $value | quote }}
-{{- end }}
-{{- end }}
 {{- if $root.Values.envFrom }}
-envFrom:
 {{- with $root.Values.envFrom }}
 {{- range $name := .configMaps }}
-  - configMapRef:
-      name: {{ $name }}
+- configMapRef:
+    name: {{ $name }}
 {{- end }}
 {{- range $name := .secrets }}
-  - secretRef:
-      name: {{ $name }}
+- secretRef:
+    name: {{ $name }}
 {{- end }}
 {{- end }}
 {{- end -}}
+{{- end }}
+{{- with $root.Values.env }}
+env:
+{{- range $name, $value := . }}
+  - name: {{ $name }}
+    value: {{ default "" $value | quote }}
+{{- end }}
+{{- end }}
 {{- end -}}