Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monochart] Fix bugs, remove dependency on obsolescent Kubernetes repo #256

Merged
merged 1 commit into from
Aug 12, 2020
Merged

[monochart] Fix bugs, remove dependency on obsolescent Kubernetes repo #256

merged 1 commit into from
Aug 12, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Aug 12, 2020

what

In [monochart]:

  • Fix incorrect reference to serviceAccount in jobs.yaml
  • Use empty maps rather than nil for default empty map values
  • Remove dependency on obsolescent Kubernetes incubator Helm repo by copying needed templates

why

  • Caused error when defining a job
  • Caused unnecessary warning messages
  • Repo scheduled to be marked obsolete on Nov 13, 2020

@Nuru Nuru requested review from osterman, goruha, maximmi and aknysh August 12, 2020 19:42
@Nuru Nuru merged commit 08e9335 into master Aug 12, 2020
@Nuru Nuru deleted the monochart branch August 12, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@goruha goruha Awaiting requested review from goruha

@maximmi maximmi Awaiting requested review from maximmi

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @osterman