Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add load_balancing_anomaly_mitigation to TG #193

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

mschfh
Copy link
Contributor

@mschfh mschfh commented Nov 25, 2024

what

Add load_balancing_anomaly_mitigation variable

references

lb_target_group

@mschfh mschfh requested review from a team as code owners November 25, 2024 12:48
@mergify mergify bot added the triage Needs triage label Nov 25, 2024
@nitrocode
Copy link
Member

/terratest

Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll approve and wait for another reviewer just in case

@mergify mergify bot removed the triage Needs triage label Nov 26, 2024
@GabisCampana
Copy link

@johncblandii @aknysh

Copy link
Contributor

@oycyc oycyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a contributor but was looking for the Terraform support on this and noticed this module didn't have it, then saw this PR. Hope it gets merged soon! 🎉

@mihaiplesa
Copy link

@joe-niland @johncblandii if you could help with review please, much appreciated.

Copy link
Member

@joe-niland joe-niland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihaiplesa thanks - looks good - just one question

variables.tf Show resolved Hide resolved
@joe-niland joe-niland added the patch A minor, backward compatible change label Dec 4, 2024
@joe-niland
Copy link
Member

/terratest

@joe-niland joe-niland enabled auto-merge (squash) December 5, 2024 00:17
@joe-niland joe-niland merged commit 08358de into cloudposse:main Dec 5, 2024
27 checks passed
Copy link
Contributor

github-actions bot commented Dec 5, 2024

These changes were released in v2.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants