Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin_access_control_id feature #112

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Genesys05
Copy link
Contributor

what

  • add origin_access_control_id optional variable to define origin_access_control on Cloudfront
  • add origin_access_control_id argument on cloudfront_distribution resource
  • Update the Readme with new vars

why

I done that because before you can't use Origin access control with this module.

@Genesys05 Genesys05 requested review from a team as code owners December 5, 2023 16:37
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

Copy link

mergify bot commented Mar 10, 2024

Thanks @Genesys05 for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage needs-test Needs testing labels Mar 10, 2024
@hans-d
Copy link

hans-d commented Mar 10, 2024

/terratest

1 similar comment
@rlee89
Copy link

rlee89 commented May 29, 2024

/terratest

@jgalais
Copy link

jgalais commented Jul 23, 2024

Message added to review this PR in #pr-reviews of Cloudposse Slack.

@goruha
Copy link
Member

goruha commented Jul 24, 2024

/terratest

@Genesys05 Genesys05 force-pushed the feature_origin_access_control_id branch from e6956ce to bff8347 Compare July 24, 2024 23:07
@Genesys05 Genesys05 force-pushed the feature_origin_access_control_id branch from bff8347 to 3216561 Compare July 24, 2024 23:14
@Nuru Nuru requested review from korenyoni and removed request for dotCipher July 24, 2024 23:46
@Nuru
Copy link
Contributor

Nuru commented Jul 24, 2024

/terratest

@Nuru Nuru added enhancement New feature or request and removed triage Needs triage needs-test Needs testing labels Jul 25, 2024
@Nuru Nuru merged commit cfebe9f into cloudposse:main Jul 25, 2024
38 of 47 checks passed
Copy link

These changes were released in v1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants