Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added passing of ipv6_enabled for aaaa record creation #44

Merged
merged 2 commits into from
Nov 14, 2020
Merged

added passing of ipv6_enabled for aaaa record creation #44

merged 2 commits into from
Nov 14, 2020

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Nov 11, 2020 •
edited
Loading

what

  • added ipv6_enabled option to Route53 alias module so it will create AAAA records in addition to A ones

why

  • AAAA were not being created

references

@mihaiplesa mihaiplesa requested review from a team as code owners November 11, 2020 06:05
@SweetOps
Copy link

/test all

@SweetOps SweetOps added the fix label Nov 14, 2020
@SweetOps SweetOps merged commit 692e9cb into cloudposse:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SweetOps SweetOps SweetOps approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaiplesa @SweetOps