Update Terraform cloudposse/s3-log-storage/aws to v0.26.0 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
This pull request is now in conflict. Could you fix it @renovate[bot]? 🙏 |
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/cloudposse-s3-log-storage-aws-0.x
branch
from
90d98ff to
2411bd4
Compare
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_31 Fixed /launch-template.tf aws_launch_template.default
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_31 Fixed /launch-template.tf aws_launch_template.default
cloudposse-mergebot
previously approved these changes
Dec 7, 2021
Nuru
added
the
no-release
Nuru
previously requested changes
Apr 3, 2022
mergify
bot
dismissed
Nuru’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_VUL_2 Added /test/src/go.sum Vulnerable go.sum
cloudposse-mergebot
approved these changes
Apr 4, 2022
Nuru
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.24.1->0.26.0Release Notes
cloudposse/terraform-aws-s3-log-storage
v0.26.0Compare Source
Add S3 bucket ownership controls @max-lobur (#61)
#### what * Set aws_s3_bucket_ownership_controls to BucketOwnerPreferred #### why * Per [docs](https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html) this setting will let object uploader decide ownership. If `bucket-owner-full-control` ACL is specified, the bucket account take ownership, otherwise the writer account keeps ownership. Bucket on its side may enforce presence of the `bucket-owner-full-control` ACL which we already do when needed. So this setting was the only missing piece to make ownership work like we expected * I found no use cases for the other value of this resource: `ObjectWriter`. It corresponds to legacy S3 behavior which was broken for us. Decided to always set to `BucketOwnerPreferred` and not allow to customize. If the owner must be preserved, we should not pass `bucket-owner-full-control` - this is a more clear way to control the behavior. #### references * https://aws.amazon.com/blogs/storage/enforcing-ownership-of-amazon-s3-objects-in-a-multi-account-environment/ * https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html * https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_ownership_controls#ObjectWriterv0.25.0Compare Source
Add support for bucket notifications @max-lobur (#60)
#### what * Add support for bucket notifications * Only SQS destination for now #### why * To enable log collectionConfiguration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.