Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont send ssl_support_method for default certificate #80

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

rusowyler
Copy link
Contributor

what

  • Don't send ssl_support_method when using cloudfront_default_certificate

why

  • It's only required if you specify acm_certificate_arn or iam_certificate_id
  • Sending it will cause Terraform to try to update CF on every deploy
  ~ viewer_certificate {
      + ssl_support_method             = "sni-only"
        # (2 unchanged attributes hidden)
    }
    # (5 unchanged blocks hidden)

@rusowyler rusowyler requested review from a team as code owners January 2, 2022 15:54
@rusowyler rusowyler requested a review from a team as a code owner January 2, 2022 15:54
@Gowiem
Copy link
Member

Gowiem commented Jan 3, 2022

/test all

@Gowiem Gowiem self-requested a review January 3, 2022 15:31
@Gowiem Gowiem added the patch A minor, backward compatible change label Jan 3, 2022
@Gowiem Gowiem merged commit 9f0b065 into cloudposse:master Jan 3, 2022
@Gowiem
Copy link
Member

Gowiem commented Jan 3, 2022

Thanks for the contribution @rusowyler! Released as 0.24.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants