Output variable was referencing incorrect value (#7)

cloudposse · Feb 6, 2018 · 58181b9 · 58181b9
1 parent ec81678
commit 58181b9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -33,7 +33,7 @@ aws acm request-certificate --domain-name example.com --subject-alternative-name
 | `attributes`                   | `[]`                   | Additional attributes (e.g. `policy` or `role`)                                                                                                                   | No       |
 | `tags`                         | `{}`                   | Additional tags  (e.g. `map("BusinessUnit","XYZ")`                                                                                                                | No       |
 | `acm_certificate_arn`          | ``                     | Existing ACM Certificate ARN                                                                                                                                      | No       |
-| `aliases`                      | `[]`                   | List of aliases                                                                                                                                                   | Yes      |
+| `aliases`                      | `[]`                   | List of aliases as a FQDN (e.g. `["www.example.com"]`)                                                                                                                                                   | Yes      |
 | `allowed_methods`              | `["*"]`                | List of allowed methods (e.g. ` GET, PUT, POST, DELETE, HEAD`) for AWS CloudFront                                                                                 | No       |
 | `cached_methods`               | `["GET", "HEAD"]`      | List of cached methods (e.g. ` GET, PUT, POST, DELETE, HEAD`)                                                                                                     | No       |
 | `comment`                      | `Managed by Terraform` | Comment for the origin access identity                                                                                                                            | No       |

diff --git a/outputs.tf b/outputs.tf
@@ -23,9 +23,9 @@ output "cf_hosted_zone_id" {
 }
 
 output "s3_bucket" {
-  value = "${null_resource.default.bucket}"
+  value = "${null_resource.default.triggers.bucket}"
 }
 
 output "s3_bucket_domain_name" {
-  value = "${null_resource.default.bucket_domain_name}"
+  value = "${null_resource.default.triggers.bucket_domain_name}"
 }
diff --git a/variables.tf b/variables.tf
@@ -20,8 +20,9 @@ variable "acm_certificate_arn" {
 }
 
 variable "aliases" {
-  type    = "list"
-  default = []
+  type        = "list"
+  description = "List of FQDN's - Used to set the Alternate Domain Names (CNAMEs) setting on Cloudfront"
+  default     = []
 }
 
 variable "origin_bucket" {