Fix terratest by ensuring IAM roles created by examples/complete are …

…unique for each run.
cloudposse · Dec 13, 2021 · 82402f1 · 82402f1
1 parent 0eab5de
commit 82402f1
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/examples/complete/deployment.tf b/examples/complete/deployment.tf
@@ -15,13 +15,12 @@ data "aws_caller_identity" "current" {
   count = local.enabled ? 1 : 0
 }
 
-
-module "statement_ids" {
+module "role_labels" {
   for_each = local.test_deployment_role_prefix_map
   source   = "cloudposse/label/null"
-  version  = "0.24.1" # requires Terraform >= 0.13.0
+  version  = "0.25.0" # requires Terraform >= 0.13.0
 
-  attributes          = split("-", each.key)
+  attributes          = concat(split("-", each.key), var.attributes)
   delimiter           = ""
   label_value_case    = "title"
   regex_replace_chars = "/[^a-zA-Z0-9]/"
@@ -33,7 +32,7 @@ data "aws_iam_policy_document" "assume_role" {
   for_each = local.test_deployment_role_prefix_map
 
   statement {
-    sid = "Enable${module.statement_ids[each.key].id}"
+    sid = "Enable${module.role_labels[each.key].id}"
     actions = [
       "sts:AssumeRole",
       "sts:TagSession"
@@ -49,9 +48,9 @@ data "aws_iam_policy_document" "assume_role" {
 
 
 resource "aws_iam_role" "test_role" {
-  for_each = local.test_deployment_role_prefix_map
+  for_each = module.role_labels
 
-  name = each.key
+  name = each.value.id
 
   assume_role_policy = data.aws_iam_policy_document.assume_role[each.key].json
 }