Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate origin.domain_name of main bucket in CF distribution #165

Closed
entr opened this issue May 15, 2021 · 2 comments
Closed

Inaccurate origin.domain_name of main bucket in CF distribution #165

entr opened this issue May 15, 2021 · 2 comments
Labels
bug 🐛 An issue with the system

Comments

@entr
Copy link

entr commented May 15, 2021 •
edited
Loading

Describe the Bug

Looks like #160 reverted changes from #149 and the domain_name of my distribution origin is incomplete s3-website.eu-central-1.amazonaws.com with website_enabled = true.
Looking at the source of 0.66.0 I can't see the changes from #149 where you started using website_endpoint instead of bucket_regional_domain_name.

Expected Behavior

origin's domain_name should start with the bucket name.

Environment:

  • OS: Ubuntu 20.04
  • Version 0.66.0
@entr entr added the bug 🐛 An issue with the system label May 15, 2021
@nitrocode
Copy link
Member

cc: @Nuru looks like a regression

@entr
Copy link
Author

entr commented May 28, 2021

Looks like #166 has fixed just that.

@entr entr closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@entr @nitrocode