Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployers #160

Merged
merged 2 commits into from
May 12, 2021
Merged

Add deployers #160

merged 2 commits into from
May 12, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented May 12, 2021

what

why

  • Along with creating the S3 bucket, enable selected IAM Principals (such as CI/CD) to upload content to it.
  • PR Make S3 website private; add S3 origin #105 made it difficult to directly access the S3 Website created with website_enabled = true. This was a breaking change, as before the S3 Website was public. Adding s3_website_password_enabled to make the Make S3 website private; add S3 origin #105 change optional and default it to false to retain backward compatibility.
  • PR Replaced old data.template_file to use latest aws provider and tf #141 was only supposed to remove the obsolete implementation of the feature, not the feature itself.
  • Best practice is not to create unneeded resources.
  • The effect of website_enabled was not well documented. The code was quite confusing to follow due to conditionals scattered throughout.

@Nuru Nuru requested review from osterman, jamengual and nitrocode May 12, 2021 08:50
@Nuru Nuru requested review from a team as code owners May 12, 2021 08:50
jamengual
jamengual previously approved these changes May 12, 2021
@Nuru
Copy link
Contributor Author

Nuru commented May 12, 2021

/test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables in additional_bucket_policy are not substituted anymore Error using existing S3 bucket in 0.59.0
2 participants