Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create ACL resource if Bucket Owner Enforced #300

Closed

Conversation

apankratiev-syberry
Copy link

@apankratiev-syberry apankratiev-syberry commented Mar 12, 2024

what

Do not create acl resource when s3_object_ownership=BucketOwnerEnforced

why

ACL is not allowed when object ownership is BucketOwnerEnforced

https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html

references

closes #299

Copy link

mergify bot commented Mar 12, 2024

Thanks @apankratiev-syberry for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the triage Needs triage label Mar 12, 2024
@joe-niland joe-niland added the patch A minor, backward compatible change label Mar 19, 2024
Copy link

mergify bot commented Mar 19, 2024

💥 This pull request now has conflicts. Could you fix it @apankratiev-syberry? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Mar 19, 2024
@joe-niland
Copy link
Member

@Mergifyio refresh

Copy link

mergify bot commented Mar 19, 2024

refresh

✅ Pull request refreshed

@apankratiev-syberry
Copy link
Author

The bug is already fixed within #301

@apankratiev-syberry apankratiev-syberry deleted the fix_acl branch March 19, 2024 10:42
@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL fails if s3_object_ownership = BucketOwnerEnforced
2 participants