Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BucketOwnerEnforced s3 buckets can't have an acl #301

Merged

Conversation

mfuhrmeisterDM
Copy link
Contributor

what

disable creating acl resource in that case.

why

BucketOwnerEnforeced s3 bucket can't have an acl.

references

@mfuhrmeisterDM mfuhrmeisterDM requested review from a team as code owners March 12, 2024 14:36
@mfuhrmeisterDM mfuhrmeisterDM changed the title BucketOwnerEnforced s3 buckets cant have an acl BucketOwnerEnforced s3 buckets can't have an acl Mar 12, 2024
@mfuhrmeisterDM mfuhrmeisterDM requested a review from a team as a code owner March 12, 2024 14:37
Copy link

mergify bot commented Mar 12, 2024

Thanks @mfuhrmeisterDM for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage needs-cloudposse Needs Cloud Posse assistance labels Mar 12, 2024
Copy link

mergify bot commented Mar 12, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@kevcube
Copy link

kevcube commented Mar 12, 2024

/terratest

Benbentwo
Benbentwo previously approved these changes Mar 12, 2024
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot removed the triage Needs triage label Mar 12, 2024
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong mergify config

@mfuhrmeisterDM mfuhrmeisterDM force-pushed the turtle/BUCKET-OWNER-ENFORCED branch from d320268 to a0b819e Compare March 12, 2024 18:31
@mergify mergify bot dismissed osterman’s stale review March 12, 2024 18:31

This Pull Request has been updated, so we're dismissing all reviews.

@osterman
Copy link
Member

/terratest

@osterman
Copy link
Member

/terratest

@Benbentwo Benbentwo enabled auto-merge (squash) March 18, 2024 18:37
@Benbentwo Benbentwo merged commit f3b5145 into cloudposse:main Mar 18, 2024
12 checks passed
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants