Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a custom cache policy #140

Merged
merged 13 commits into from
May 11, 2021

Conversation

dmattia
Copy link
Contributor

@dmattia dmattia commented Mar 17, 2021

what

This module could also create a cache policy itself if desired, I would gladly make that change.

Note: I support a module for creating cache policies: https://registry.terraform.io/modules/transcend-io/cache-policy/aws/latest

why

  • Cache Policies are the easiest (only?) way to add brotli compression in CloudFront

@dmattia dmattia force-pushed the dmattia/cache_policy branch from f30a817 to b0765e4 Compare March 17, 2021 18:57
@dmattia dmattia force-pushed the dmattia/cache_policy branch from 9108869 to f5e82ad Compare March 17, 2021 20:32
@dmattia dmattia force-pushed the dmattia/cache_policy branch from 2eee31f to ab6afc2 Compare March 17, 2021 20:43
@dmattia dmattia marked this pull request as ready for review March 18, 2021 14:40
@dmattia dmattia requested review from a team as code owners March 18, 2021 14:40
@dmattia dmattia requested review from dotCipher and adamcrews and removed request for a team March 18, 2021 14:40
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member

/test all

main.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

/test all

@justnom
Copy link

justnom commented Mar 26, 2021

@dmattia

Should we also add the cache_policy_id into the ordered_cache map?

Similar to this commit: cloudposse/terraform-aws-cloudfront-cdn@12cbfb4

@dmattia
Copy link
Contributor Author

dmattia commented Mar 26, 2021

We definitely could do that as well. Would you like me to make that change?

@justnom
Copy link

justnom commented Mar 26, 2021

We definitely could do that as well. Would you like me to make that change?

Sure, or I can do it in a separate PR after this is merged. I can't seem to suggest changes to the PR from outside the scope shown in "Files changed".

@dmattia
Copy link
Contributor Author

dmattia commented Mar 27, 2021

@justnom Awesome, let's do the ordered caches in a separate PR then 👍

@mergify
Copy link

mergify bot commented Mar 27, 2021

This pull request is now in conflict. Could you fix it @dmattia? 🙏

@dmattia dmattia removed the request for review from a team March 30, 2021 19:05
@dmattia dmattia requested review from nitrocode and removed request for a team March 30, 2021 19:05
@mergify
Copy link

mergify bot commented Mar 31, 2021

This pull request is now in conflict. Could you fix it @dmattia? 🙏

@mergify
Copy link

mergify bot commented Apr 21, 2021

This pull request is now in conflict. Could you fix it @dmattia? 🙏

@Gowiem
Copy link
Member

Gowiem commented Apr 26, 2021

@dmattia apologies for giving you conflicts yet again. This looks like a straight forward change... want to update once last time and then ping me and we'll get this merged for you?

@Gowiem
Copy link
Member

Gowiem commented Apr 26, 2021

/test all

@nitrocode
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 2efb943 into cloudposse:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants