-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a custom cache policy #140
Conversation
f30a817
to
b0765e4
Compare
9108869
to
f5e82ad
Compare
2eee31f
to
ab6afc2
Compare
/test all |
/rebuild-readme |
/test all |
/test all |
Should we also add the Similar to this commit: cloudposse/terraform-aws-cloudfront-cdn@12cbfb4 |
We definitely could do that as well. Would you like me to make that change? |
Sure, or I can do it in a separate PR after this is merged. I can't seem to suggest changes to the PR from outside the scope shown in "Files changed". |
@justnom Awesome, let's do the ordered caches in a separate PR then 👍 |
This pull request is now in conflict. Could you fix it @dmattia? 🙏 |
This pull request is now in conflict. Could you fix it @dmattia? 🙏 |
This pull request is now in conflict. Could you fix it @dmattia? 🙏 |
@dmattia apologies for giving you conflicts yet again. This looks like a straight forward change... want to update once last time and then ping me and we'll get this merged for you? |
/test all |
/rebuild-readme |
/test all |
what
This module could also create a cache policy itself if desired, I would gladly make that change.
Note: I support a module for creating cache policies: https://registry.terraform.io/modules/transcend-io/cache-policy/aws/latest
why