Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide better description for var.origin_bucket #142

Merged
merged 11 commits into from
Mar 31, 2021
Merged

Provide better description for var.origin_bucket #142

merged 11 commits into from
Mar 31, 2021

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Mar 27, 2021 •
edited
Loading

what

  • Provide better description for var.origin_bucket
  • Provide an example of reusing an s3 bucket in the README

why

  • There's some confusion whether to define this value as the bucket to be created or to reuse an existing bucket

references

@nitrocode nitrocode requested review from a team as code owners March 27, 2021 18:58
@nitrocode nitrocode requested a review from a team as a code owner March 27, 2021 18:59
@nitrocode nitrocode requested review from dotCipher and brcnblc and removed request for a team March 27, 2021 18:59
osterman
osterman reviewed Mar 27, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@nitrocode nitrocode requested a review from osterman March 27, 2021 19:11
osterman
osterman previously approved these changes Mar 27, 2021
View reviewed changes
@nitrocode nitrocode mentioned this pull request Mar 27, 2021
Closed
@nitrocode
Copy link
Member Author

/test all

@cloudposse cloudposse deleted a comment from mergify bot Mar 27, 2021
@nitrocode nitrocode requested a review from osterman March 27, 2021 22:18
@mergify
Copy link

mergify bot commented Mar 31, 2021

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode requested a review from jamengual March 31, 2021 04:08
@nitrocode
Copy link
Member Author

/test terratest

@nitrocode
Copy link
Member Author

/test test/terratest

@jamengual jamengual merged commit dd552b3 into master Mar 31, 2021
@jamengual jamengual deleted the better-description-origin-bucket branch March 31, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@brcnblc brcnblc Awaiting requested review from brcnblc

@osterman osterman Awaiting requested review from osterman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 Bucket not found
4 participants
@nitrocode @osterman @jamengual @cloudpossebot