Code

Fix: Deployment Principal ARNs#164

Code

Merged

korenyoni merged 27 commits intomastercloudposse/terraform-aws-cloudfront-s3-cdn:masterfrom fix/deployment-principal-arnscloudposse/terraform-aws-cloudfront-s3-cdn:fix/deployment-principal-arnsCopy head branch name to clipboardMay 17, 2021

+117-38

Commits

Commits on May 14, 2021

• Fix snippet passing incorrect variable name.

  korenyoni

  committed
  c2e4749

• Fix snippet: all prefixes must begin in forward slash or otherwise the bucket policy JSON will be invalid.

  korenyoni

  committed
  e3c5ea3

• Fix default for s3_access_log_bucket_name — it is supposed to be empty and there is a check for its length in locals{} that assumes it is empty by default, but it is not empty by default.

  korenyoni

  committed
  1df07a8

• Fix order of nested functions — otherwise an error occurs when comparing types.

  korenyoni

  committed
  b9b2604

• Fix minimum_protocol_version being passed when it won't be honored by AWS i.e. when s3_access_log_bucket_name is true as a result of acm_certificate_arn being unset.

  korenyoni

  committed
  49dc9b0

• Fix typo in tfvars fixtures in example.

  korenyoni

  committed
  aa68970

• Add enablement toggles to all resources in example; add tests for deployment_principal_arns.

  korenyoni

  committed
  51ee698

• Auto Format

  cloudpossebot

  committed
  0104179

• Add validation for deployment_principal_arns.

  korenyoni

  committed
  0661566

• Merge branch 'fix/deployment-principal-arns' of github.com:cloudposse/terraform-aws-cloudfront-s3-cdn into fix/deployment-principal-arns

  korenyoni

  committed
  6fdaf3b

• Auto Format

  cloudpossebot

  committed
  7e73990

• Add korenyoni to list of contributors.

  korenyoni

  committed
  95bbc11

• Merge branch 'fix/deployment-principal-arns' of github.com:cloudposse/terraform-aws-cloudfront-s3-cdn into fix/deployment-principal-arns

  korenyoni

  committed
  06b7f78

• Auto Format

  cloudpossebot

  committed
  3cefbd0

Commits on May 16, 2021

• Change testing.cloudposse.com back to *.co — the latter is the intended testing domain.

  korenyoni

  committed
  4fec68d

• Merge branch 'fix/deployment-principal-arns' of github.com:cloudposse/terraform-aws-cloudfront-s3-cdn into fix/deployment-principal-arns

  korenyoni

  committed
  c83a6ee

• Add Sid to IAM Role assume_role_policy.

  korenyoni

  committed
  07c989f

• Allow user to control minimum_protocol_version entirely, but document limitations of var.acm_certificate_arn being unset in variables.tf.

  korenyoni

  committed
  8eeda44

• Auto Format

  cloudpossebot

  committed
  38ebef4

• Remove validation as it is using functions not supported by the Terraform version being used in automated Terratest testing.

  korenyoni

  committed
  2fa01c0

• Merge branch 'fix/deployment-principal-arns' of github.com:cloudposse/terraform-aws-cloudfront-s3-cdn into fix/deployment-principal-arns

  korenyoni

  committed
  b99bc5a

• examples/complete: support entire context being disabled.

  korenyoni

  committed
  7853750

• Document in variables.tf that all prefixes must begin with '/' — now that the validation is removed.

  korenyoni

  committed
  2014b30

• Auto Format

  cloudpossebot

  committed
  efb97c5

Commits on May 17, 2021

• Revert S3 prefixes to NOT having leading slash

  Nuru

  committed
  c286551

• Auto Format

  cloudpossebot

  committed
  9ac32b6

• Fix typos in deployment.tf.

  korenyoni

  committed
  6feecd5