Add support for CloudFront functions #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjurkiewicz
requested review from
jhosteny and
adamcrews
and removed request for
a team
alexjurkiewicz
force-pushed
the
cloudfront-functions
branch
from
bc2d51b to
28c0315
Compare
This follows the naming of Terraform's AWS provider. Lambda@Edge functions are "lambda functions", whereas CloudFront functions are simply "functions".
alexjurkiewicz
force-pushed
the
cloudfront-functions
branch
from
1d96fcc to
ac97daa
Compare
alexjurkiewicz
commented
May 19, 2021
| @@ -462,6 +470,14 @@ resource "aws_cloudfront_distribution" "default" { | |||
| lambda_arn = lambda_function_association.value.lambda_arn | |||
| } | |||
| } | |||
|
|
|||
| dynamic "function_association" { | |||
| for_each = lookup(ordered_cache_behavior.value, "function_association", []) | |||
There was a problem hiding this comment.
this is a lookup for backwards compatibility
|
I've tested this by deploying my own distribution with an attached function 👍 |
|
By adding this, shouldn't we also update the aws provider pin to > 3.41.0 ? It would be nice to link the docs for the |
|
Thanks for the feedback, done both! |
|
/test all |
nitrocode
approved these changes
May 25, 2021
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This follows the naming of Terraform's AWS provider. Lambda@Edge
functions are "lambda functions", whereas CloudFront functions are
simply "functions".
references