Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Support for Origin Groups (Failover Origins) #174

Merged
merged 19 commits into from
Jul 2, 2021
Merged

Feat: Add Support for Origin Groups (Failover Origins) #174

merged 19 commits into from
Jul 2, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Jul 1, 2021 •
edited
Loading

what

  • Add Support for Origin Groups (failover origins)
  • Add tests for var.s3_origins and var.custom_origins
  • Add functionality such that if s3_origin_config.origin_access_identity in var.s3_origins is null or an empty string, translate it to the origin_access_identity used by the origin created by the module.

why

  • Certain CloudFront distributions require origins to be backed by failover origins. This can only be done using Origin Groups, which prior to this PR is not supported by the module.
  • The variables var.s3_origins and var.custom_origins were not tested using the test suite.

references

@korenyoni korenyoni force-pushed the feat/failover-origins branch from 61d97ba to 9242891 Compare July 1, 2021 02:01
@korenyoni korenyoni force-pushed the feat/failover-origins branch from 876a395 to 2bec408 Compare July 1, 2021 07:08
@korenyoni korenyoni marked this pull request as ready for review July 1, 2021 07:29
@korenyoni korenyoni requested review from a team as code owners July 1, 2021 07:29
@korenyoni korenyoni requested review from srhopkins and 3h4x and removed request for a team July 1, 2021 07:29
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni changed the title Feat: failover origins Feat: Add Support for Origin Groups (Failover Origins) Jul 1, 2021
korenyoni and others added 2 commits July 1, 2021 04:24
@korenyoni
If s3_origin_config.origin_access_identity in var.s3_origins is null …
56ba422 
…or the empty string, translate it to the origin_access_identity used by the origin created by the module.
@cloudpossebot
Auto Format
1868c75
@korenyoni
Copy link
Member Author

/test all

nitrocode
nitrocode reviewed Jul 1, 2021
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 1, 2021
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested a review from nitrocode July 1, 2021 15:25
@korenyoni
Copy link
Member Author

Tests are failing now. Will fix when I get a chance.

@korenyoni
Copy link
Member Author

/test all

nitrocode
nitrocode previously approved these changes Jul 2, 2021
View reviewed changes
@korenyoni korenyoni requested a review from nitrocode July 2, 2021 19:06
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni merged commit 138e146 into master Jul 2, 2021
@korenyoni korenyoni deleted the feat/failover-origins branch July 2, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins

@3h4x 3h4x Awaiting requested review from 3h4x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korenyoni @nitrocode @cloudpossebot