Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trusted_* vars per ordered_cache #176

Conversation

martinlindner
Copy link
Contributor

what

Add individual trusted_signers, trusted_key_groups attributes to var.ordered_cache.

why

  • "Private content" / signature checks should be configurable on a per-behavior level instead of just enforcing the global settings for all.

@martinlindner martinlindner requested review from a team as code owners July 7, 2021 12:02
@martinlindner martinlindner requested review from Makeshift and brcnblc and removed request for a team July 7, 2021 12:02
@nitrocode
Copy link
Member

/test all

@martinlindner
Copy link
Contributor Author

Quick ping @Makeshift, @brcnblc. Sorry to bug you. Any chance to get this reviewed?

I actually have a prod use case for per-behavior trusted_key_groups, and it'd be awesome if I could use this module directly instead of my own fork.

@nitrocode nitrocode merged commit ce3f377 into cloudposse:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants