Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sensitive values in outputs #183

Closed

Conversation

sebastianmacarescu
Copy link

@sebastianmacarescu sebastianmacarescu commented Aug 23, 2021

#182

references

  • closes #182

@sebastianmacarescu sebastianmacarescu requested review from a team as code owners August 23, 2021 08:10
@sebastianmacarescu
Copy link
Author

Can we get this merged?

@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

I believe sensitive is a terraform 0.15 feature

https://www.terraform.io/docs/language/functions/sensitive.html

Note: This function is only available in Terraform v0.15 and later.

We're currently have a pin to allow this module to work on terraform 0.13 and above

terraform {
required_version = ">= 0.13.0"

@nitrocode
Copy link
Member

Here's something else that's also interesting. The sensitive flag isn't even on the aws_cloudfront_distribution resource's argument origin.origin_id schema

https://github.com/hashicorp/terraform-provider-aws/blob/e26f89a007dbddb3d967a3b506a129e6605f4846/aws/resource_aws_cloudfront_distribution.go#L568-L572

If the output was sensitive, shouldn't it have the Sensitive: true flag enabled for it like for other resources ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants