Migrate to README.yaml format #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarkis
previously requested changes
Jul 4, 2018
outputs.tf
Outdated
| } | ||
|
|
||
| output "cf_arn" { | ||
| value = "${aws_cloudfront_distribution.default.arn}" | ||
| value = "${aws_cloudfront_distribution.default.arn}" | ||
| description = "ID of AWS CloudFront distribution" |
variables.tf
Outdated
| @@ -32,7 +32,8 @@ variable "tags" { | |||
| } | |||
|
|
|||
| variable "enabled" { | |||
| default = "true" | |||
| default = "true" | |||
| description = "State of CloudFront" | |||
There was a problem hiding this comment.
Boolean which determines if CloudFront resources are created
variables.tf
Outdated
| default = ["*"] | ||
| type = "list" | ||
| default = ["*"] | ||
| description = "List of allowed headers for S3 bucket" |
There was a problem hiding this comment.
unneeded extra space between words headers and for
variables.tf
Outdated
| default = ["GET"] | ||
| type = "list" | ||
| default = ["GET"] | ||
| description = "List of allowed methods (e.g. ` GET, PUT, POST, DELETE, HEAD`) for S3 bucket" |
There was a problem hiding this comment.
Do we need the backtick here? If so maybe we should do e.g. GET, PUT, ...
variables.tf
Outdated
| default = [] | ||
| type = "list" | ||
| default = [] | ||
| description = "List of allowed origins (e.g. ` example.com, test.com`) for S3 bucket" |
variables.tf
Outdated
| default = ["DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT"] | ||
| type = "list" | ||
| default = ["DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT"] | ||
| description = "List of allowed methods (e.g. ` GET, PUT, POST, DELETE, HEAD`) for AWS CloudFront" |
There was a problem hiding this comment.
yea, let's just remove the back tick
variables.tf
Outdated
| default = ["GET", "HEAD"] | ||
| type = "list" | ||
| default = ["GET", "HEAD"] | ||
| description = "List of cached methods (e.g. ` GET, PUT, POST, DELETE, HEAD`)" |
osterman
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
README.yamlwhy