Added support for forward_cookies_whitelisted_names #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaljanicki
requested review from
r351574nc3 and
Makeshift
and removed request for
a team
|
/test all |
|
Sorry for hassling @nitrocode , but it'd make my life so much easier if we could get it merged. Let me know if there's anything I should add here :) |
nitrocode
approved these changes
Nov 24, 2021
|
thanks @rafaljanicki for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
I've added support for whitelisted_names (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_distribution#whitelisted_names) if forward_cookies is set to "whitelist"
why
Currently, the only option to forward cookies is to set it to "all" which isn't perfect
references