Feat: Add external_aliases Which Will Not Have CNAMEs Created for Them
#199
Conversation
mburns
requested review from
max-lobur and
brcnblc
and removed request for
a team
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_27 Added /main.tf aws_cloudfront_distribution.default BC_AWS_GENERAL_56 Added /main.tf aws_s3_bucket.origin BC_AWS_NETWORKING_52 Added /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_72 Added /main.tf aws_s3_bucket.origin
|
@mburns are you able to please add BridgeCrew exceptions for the failing checks outlined in this PR? |
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_27 Fixed /main.tf aws_cloudfront_distribution.default BC_AWS_GENERAL_56 Fixed /main.tf aws_s3_bucket.origin BC_AWS_NETWORKING_52 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_72 Fixed /main.tf aws_s3_bucket.origin
mergify
bot
dismissed
korenyoni’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
This reverts commit fac591c.
|
Hey @mburns — I see that you reverted the BridgeCrew supressions, was there a particular reason why? |
|
HI @korenyoni, just troubleshooting, sorry. It looked like the errors were fixed just by merging the latest master. I'll re-apply the change. |
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_27 Fixed /main.tf aws_cloudfront_distribution.default BC_AWS_NETWORKING_52 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_56 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_72 Fixed /main.tf aws_s3_bucket.origin
|
/test all |
|
@mburns I'm honestly not sure why the BridgeCrew check is still failing — I will have to take a closer look tomorrow.
|
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_NETWORKING_52 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_56 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_27 Fixed /main.tf aws_cloudfront_distribution.default BC_AWS_GENERAL_72 Fixed /main.tf aws_s3_bucket.origin
…3 bucket resource definition.
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_27 Fixed /main.tf aws_cloudfront_distribution.default BC_AWS_NETWORKING_52 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_56 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_72 Fixed /main.tf aws_s3_bucket.origin
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_56 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_72 Fixed /main.tf aws_s3_bucket.origin BC_AWS_NETWORKING_52 Fixed /main.tf aws_s3_bucket.origin BC_AWS_GENERAL_27 Fixed /main.tf aws_cloudfront_distribution.default
|
/test all |
|
I'm still not sure why BC is failing in the GitHub checks API. Originally, it was because I'm not sure why it's still happening though. As you can see, it's passing in BC itself.
@mburns I've also taken over your PR and just expanded the suppression comments and moved the suppressions to the top of the resource definition blocks. Anyways, I'm going to merge this in and hope the BC errors do not keep happening in subsequent PRs. |
korenyoni
changed the title
external_aliases Which Will Not Have CNAMEs Created for Them
korenyoni
added
no-release
what
why
dns_alias_enabled, but allows for a mixture of DNS providers for a single CloudFront Distribution