Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Do Not Hardcode AWS Partition #203

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Fix: Do Not Hardcode AWS Partition #203

merged 4 commits into from
Dec 13, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Dec 13, 2021 •
edited
Loading

what

  • Do not hardcode AWS partition.

why

  • Adds support for partitions other than aws, such as aws-us-gov.

references

@korenyoni korenyoni requested review from a team as code owners December 13, 2021 16:22
@korenyoni korenyoni requested review from r351574nc3 and joe-niland and removed request for a team December 13, 2021 16:22
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni added the patch A minor, backward compatible change label Dec 13, 2021
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni added the no-release Do not create a new release (wait for additional code changes) label Dec 13, 2021
@korenyoni korenyoni merged commit 5005fd4 into master Dec 13, 2021
@korenyoni korenyoni deleted the fix/aws-partition branch December 13, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 was automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes) patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support other partitions like aws-cn aws-us-gov
3 participants
@korenyoni @max-lobur @cloudpossebot